Repository navigation
Preserve static License-File metadata from pyproject.toml - #5350
Open
wangyusheng1985 wants to merge 1 commit into
Open
wangyusheng1985 wants to merge 1 commit into
wangyusheng1985 wants to merge 1 commit into
Conversation
Glob expansion of license-files previously replaced the parsed list with a plain list, so PKG-INFO always marked License-File as Dynamic. Keep the static marker when the field came from a config file. Closes pypa#4960 Signed-off-by: yusheng.wang <yusheng.wang@chaitin.com>
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Author
|
@Mergifyio queue |
Contributor
☑️ Command disallowed due to command restrictions in the Mergify configuration.Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4960.
When
license-filesis set inpyproject.tomlorsetup.cfg, glob expansion no longer drops the static marker. PKG-INFO therefore omitsDynamic: license-filefor that case.Default glob discovery still marks
License-Fileas Dynamic.Test plan
pytest setuptools/tests/test_core_metadata.py::TestPEP643 setuptools/tests/config/test_apply_pyprojecttoml.py::TestStaticConfig