Repository navigation
Conversation
configure_union_passthrough was unwrapping every type alias to its base, so a custom structure hook registered for the alias never ran when the alias appeared inside a passthrough union (e.g. Trimmed | int). Only unwrap aliases that still use the default type-alias factory; leave aliases with a dedicated hook in spillover so converter.structure can apply them. Fixes python-attrs#797
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #797
configure_union_passthroughwas unwrapping every PEP 695 type alias to its base type. A custom structure hook registered for the alias therefore never ran when the alias appeared inside a passthrough union (Trimmed | intreturned the raw string).Only unwrap aliases that still use the default type-alias factory. Aliases with a dedicated hook stay in spillover so
converter.structureapplies them.Checklist