Repository navigation
Conversation
…tion create_default_dis_func used fields_dict, so a dataclass Field with only default_factory kept .default as MISSING and was treated as required. That made omit_if_default payloads with those fields silently pick the other union member. Use adapted_fields, which maps default_factory to Factory, matching attrs Factory and plain dataclass defaults. Fixes python-attrs#796
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #796
create_default_dis_funcusedfields_dict, so a dataclassFieldwith onlydefault_factorykept.defaultasMISSINGand was treated as required. Withomit_if_default=True, a round-trip ofD1(x=1, tags=[])againstUnion[D1, D2]silently becameD2(x=1).Use
adapted_fields, which already mapsdefault_factorytoFactory, matching attrsFactoryand plain dataclassdefault. The union then raises the same "Could not disambiguate" error as the attrs equivalent.Checklist