Repository navigation
Conversation
…-attrs#796) A dataclass field that sets only `default_factory` has a raw `Field.default` of `MISSING`, so the disambiguator treated it as a required field and a payload omitting it failed to structure as that class. Read defaults from `adapted_fields` instead, which normalizes `default_factory` to a `Factory`, matching the behavior of attrs `factory` fields. Adds a regression test and a HISTORY.md entry.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #796.
create_default_dis_funcread each field's default from the rawdataclasses.Fieldviafields_dict. A field that sets onlydefault_factoryhasField.default == MISSING, so it was treated as a required field: the class could never be chosen as the disambiguation fallback, and a payload omitting that field raisedCouldn't disambiguateinstead of structuring as that class. The attrs equivalent (factory=...) already behaved correctly, so dataclasses and attrs disagreed.Defaults are now read from
adapted_fields, which mapsdefault_factoryto aFactory, matching attrsfactoryfields.fields_dictand theMISSINGimport are no longer used here and are removed.Added
test_dataclasses_default_factory, covering both union orders across all converter configurations (it fails before the change and passes after), and a HISTORY.md entry.