Repository navigation
Fix pyyaml converter crashing on non-enum str subclasses - #804
Open
Debasishhh wants to merge 4 commits into
Open
Debasishhh wants to merge 4 commits into
Debasishhh wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PyYAML preconf converter's
strunstructure hook assumes anystrsubclass is a string enum and returnsv.value. Any other subclass crashes:Returning the value unchanged isn't enough, because
yaml.safe_dumprefuses str subclasses too. So the hook now keeps the enum path and turns any other subclass into a plainstr. I moved it into a small named function since the one-line conditional was getting hard to read.Added a test with a plain
class MyStr(str)that checks the unstructured value is an exactstrand thatdumps/loadsround-trips. The full test suite passes locally, andruff check/ruff formatare clean.