Skip to content

Smart constructor for creating sheet names - #202

Merged
qrilka merged 2 commits into
qrilka:masterfrom
nitinprakash96:nitin/sheetname
Nov 13, 2025
Merged

qrilka merged 2 commits into
qrilka:masterfrom
nitinprakash96:nitin/sheetname

Conversation

@nitinprakash96

@nitinprakash96 nitinprakash96 commented Oct 31, 2025 •

Copy link
Copy Markdown
Contributor

Towards #155

TODO:

  • Consolidate all the places where we are passing Text for sheet names internally.

@qrilka

qrilka commented Nov 12, 2025

Copy link
Copy Markdown
Owner

Hi @nitinprakash96
No objections for the change but what about failing CI, is that expected?

@nitinprakash96

nitinprakash96 commented Nov 13, 2025 •

Copy link
Copy Markdown
Contributor Author

The failure was because I accidentally removed one of the imports.
Also, looks like sheet name is passed around as Text in a lot of places. That can allow passing around restricted characters. But at least with exposing a function like this allows the user to build safe sheet names. I'll see how to take care of internal calls in a followup PR.

@nitinprakash96
nitinprakash96 marked this pull request as ready for review November 13, 2025 02:32
@qrilka
qrilka merged commit f1fff99 into qrilka:master Nov 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants