Repository navigation
monoid of no mappend, monad of no return - #204
Merged
Merged
Conversation
Contributor
Author
|
hm, should xlsx/src/Codec/Xlsx/Parser/Internal/Fast.hs Lines 78 to 79 in 3e59f8d be changed too? |
Contributor
|
It would be future proofing to do so. |
applies https://gist.github.com/L0neGamer/3df4008fd458030cf3cf2c374ccfa3ec and removes return from ChildCollector instance
Contributor
Author
|
OK, removed that one too :) still builds and tests fine on my laptop. |
Owner
|
I almost don't follow Haskell these days but I will try to find some time next week to bump versions and crate a new release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. haskell/core-libraries-committee#418
this applies the changes from https://gist.github.com/L0neGamer/3df4008fd458030cf3cf2c374ccfa3ec
tested on 9.14.1, passes
cabal build && cabal test