Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg_deps_explain(".", "foobar")fails in the subprocess:pkg_deps_explain_internal()finds the requested package withmatch(pkg, data$ref), but for a local path the solution'srefislocal::., not..match()returnsNA, andadjlist[[NA]] <- ...is the error. Thelocal::.spelling worked, which is the workaround in the issue.When there is no exact match it now uses the row marked
directin the solution. Ifpkgmatchesrefas before, nothing changes.The new
tests/testthat/test-deps-explain.Ruses two local packages and checks that"."gives the same paths as"local::.". It fails on main and passes here. I also compared 18pkg_deps_explain()calls on main and on this branch (.,./, an absolute path,local::.,upgrade = FALSE,dependencies = FALSE, repeated and self deps, and CRAN,cran::,standard::, versioned and GitHub refs). Everything that worked before gives the same output; the local path calls that errored now work. The full suite has the same failures on both builds (keyring, PPM SSO), minus the new test.Closes #470