Skip to content

Allow required options to be initialised with string keys #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoelTowell wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow required options to be initialised with string keys #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8e2f5e
Add failing spec
JoelTowell Aug 18, 2026
63a7b81
Fix required option lookup for string keys
JoelTowell Aug 18, 2026
5dfcbc9
:cop:
JoelTowell Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/thor/parser/options.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,11 @@ def initialize(hash_options = {}, defaults = {}, stop_on_unknown = false, disabl
super(options)

# Add defaults
option_lookup = Thor::CoreExt::HashWithIndifferentAccess.new(hash_options)

defaults.each do |key, value|
@assigns[key.to_s] = value
@non_assigned_required.delete(hash_options[key])
@non_assigned_required.delete(option_lookup[key])
end

@shorts = {}
Expand Down
12 changes: 12 additions & 0 deletions spec/base_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,18 @@ def hello
expect(base.options[:third]).to eq(4)
end

it "allows required options to be given as symbols or strings" do
counter = Class.new(MyCounter) do
class_option :third, required: true, type: :numeric
end

base = counter.new [1, 2], third: 4
expect(base.options[:third]).to eq(4)

base = counter.new [1, 2], "third" => 4
expect(base.options[:third]).to eq(4)
end

it "creates options with indifferent access" do
base = MyCounter.new [1, 2], third: 3
expect(base.options["third"]).to eq(3)
Expand Down