Repository navigation
Conversation
Assisted-by: OpenAI GPT-6 <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integer
dtyperesults from the Pythoncdistandcpdistimplementations round exact halfway scores to even, while the native implementation usesstd::llroundand rounds them away from zero. For example,Levenshtein.normalized_similarity("ab", "ac")stored asuint8is0in Python and1in C++.This change uses the native rounding rule for Python integer matrices, including both symmetric
cdistpaths. Truncating before comparing the fractional remainder preserves exact integer scores and supports NumPy scalars, Decimal, and Fraction without introducing float conversion. Floating-point matrix output is unchanged.Validation:
The tests used current Python source with the native modules from the matching 3.14.6 Windows wheel as the C++ reference. A fresh native build was not performed because the local environment has no C++ compiler. For the scorer typing script, its bare
pythonsubprocess command was routed to the active virtualenv interpreter to avoid Windows selecting the base interpreter.AI assistance: implemented and tested with OpenAI Codex (GPT-6), followed by independent agent review and another review of the resulting correction. This PR is submitted under the account owner's explicit authorization.