Repository navigation
Conversation
handle_vfs_event unwrapped canonicalize on each event's path, and events are handled after they happen on disk. A temp file renamed over its target, or a folder removed right after its children, killed the server with a NotFound panic at change_processor.rs lines 172 and 179. Canonicalize the deepest ancestor that still exists instead, so these events are handled like any other change. The release workflow is trimmed to the Windows exe, as upstream's also uploads the plugin to Roblox with secrets this fork doesn't have. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
This feels like it was mistakenly opened as a PR considering it includes the change to our workflow. Either way, we wouldn't accept this solution as we have a more permanent fix in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_vfs_event unwrapped canonicalize on each event's path, and events are handled after they happen on disk. A temp file renamed over its target, or a folder removed right after its children, killed the server with a NotFound panic at change_processor.rs lines 172 and 179.
Canonicalize the deepest ancestor that still exists instead, so these events are handled like any other change.
The release workflow is trimmed to the Windows exe, as upstream's also uploads the plugin to Roblox with secrets this fork doesn't have.