Repository navigation
Conversation
…t worth the msrv update)
Member
Author
|
...I failed to consider the logistics of tests on GitHub and it has become late. I will fix those tomorrow, if they can be fixed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roblox has requested that we swap to a new endpoint for uploading files. This is because this endpoint sends things through their asset pipeline, which allows it to do things like granting asset permissions and will allow it to do things like support the drafts feature which is coming soon(tm).
However, this isn't a straightforward change because it goes from a simple send-and-forget request to one that requires polling. So, here we are. A happy side effect of this case is that we no longer need to pass
--universe_idto upload places.A downside is that this requires new scopes for API keys. I've tried to document that as best I can, but someone is inevitably going to get shot in the foot by this. I think there's only so much we can do on that front though.
I also took the time to fix uploading with Cookies (even though Roblox don't document this endpoint, I can observe it directly within Studio and its usage is the same as the documented one, only with a cookie), and to enable kebab-case for parameters because it's always bothered me.
I've tried to make this code reusable when I can, and to reduce duplication. The result is a bit messy when it comes to passing authentication and CSRF tokens but is otherwise pretty nice.