Repository navigation
Fix missing input parsing in Chapter 7 guessing game example - #4855
Open
Sha1rholder wants to merge 1 commit into
Open
Sha1rholder wants to merge 1 commit into
Sha1rholder wants to merge 1 commit into
Conversation
Parse the guess as u32 before comparing it with the secret number. The example reuses the incomplete code from Listing 2-4 without the conversion needed to compile.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Chapter 7 example in
listings/ch07-managing-growing-projects/no-listing-01-use-std-unnested/src/main.rsfails to compile with E0308 becauseguessis aStringwhilesecret_numberis an integer.This is the same type mismatch reported in #3562. In Chapter 2, Listing 2-4 intentionally does not compile, and the following explanation introduces the missing conversion. The Chapter 7 example carries over that incomplete code, where the omission no longer serves that teaching purpose and should be fixed.
Parse the trimmed input as
u32before comparing it with the secret number, using the conversion already introduced in Chapter 2.The change is outside the
hereanchor, so the displayedusestatements remain unchanged.Validation:
cargo checkwith E0308cargo check