Skip to content

fix(notifications): align chevron disclosure and expose expanded state - #4016

Merged
setchy merged 1 commit into
mainfrom
fix/notification-chevron-a11y
Nov 4, 2026
Merged

setchy merged 1 commit into
mainfrom
fix/notification-chevron-a11y

Conversation

@setchy

@setchy setchy commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Summary

Aligns the account/product notification chevrons with standard disclosure conventions and exposes the expanded state to assistive technology.

  • Closed sections use a right chevron; open sections use a down chevron.
  • Empty sections follow the same rule instead of using a left (back/previous) chevron.
  • Removed the no-records-specific tooltip; the toggle now always describes its action (Show/Hide notifications), matching populated sections.
  • Simplified getChevronDetails to depend only on visibility.
  • Added aria-expanded to the account and product toggles.

aria-controls is intentionally omitted for consistency with gitify and to avoid referencing conditionally unmounted content.

Testing

  • pnpm exec tsc --noEmit
  • pnpm exec biome check on changed files
  • Targeted Vitest suites for notification rows and display helpers
  • pnpm i18n:check

- use right/down chevrons for closed/open sections, including empty ones
- drop the no-records left chevron and state-specific tooltip
- expose aria-expanded on account and product toggles

Signed-off-by: Adam Setch <adam.setch@outlook.com>
@netlify

netlify Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for atlassify canceled.

Name Link
🔨 Latest commit 0b6b013
🔍 Latest deploy log https://app.netlify.com/projects/atlassify/deploys/6aeb175518e8ceb5b2fcf79c

@github-actions github-actions Bot added the bug Something isn't working label Nov 4, 2026
@gitar-bot

gitar-bot Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Changing notification disclosure icons and adding aria-expanded alters UI accessibility state; mismatches could mislead users about whether notifications are visible.

Aligns account and product notification chevrons with standard disclosure conventions: right when closed, down when open, including empty sections. Removes the no-records tooltip so the toggle always reads Show or Hide notifications, and exposes expanded state via aria-expanded. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

@setchy
setchy merged commit a36f554 into main Nov 4, 2026
25 checks passed
@setchy
setchy deleted the fix/notification-chevron-a11y branch November 4, 2026 11:50
@github-actions github-actions Bot added this to the Release 3.17.3 milestone Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in Atlassify v3.17.3! 🎉

Downloads for macOS, Windows, and Linux are available on the release page.

Thanks for helping make Atlassify better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant