Repository navigation
fix(notifications): align chevron disclosure and expose expanded state - #4016
Conversation
- use right/down chevrons for closed/open sections, including empty ones - drop the no-records left chevron and state-specific tooltip - expose aria-expanded on account and product toggles Signed-off-by: Adam Setch <adam.setch@outlook.com>
✅ Deploy Preview for atlassify canceled.
|
Code Review ✅ Approved🟡 Medium risk · Changing notification disclosure icons and adding aria-expanded alters UI accessibility state; mismatches could mislead users about whether notifications are visible. Aligns account and product notification chevrons with standard disclosure conventions: right when closed, down when open, including empty sections. Removes the no-records tooltip so the toggle always reads Show or Hide notifications, and exposes expanded state via aria-expanded. No issues found. VerificationRules No rules evaluated Functional validation Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
|
|
🎉 This pull request is included in Atlassify v3.17.3! 🎉 Downloads for macOS, Windows, and Linux are available on the release page. Thanks for helping make Atlassify better! |



Summary
Aligns the account/product notification chevrons with standard disclosure conventions and exposes the expanded state to assistive technology.
Show/Hidenotifications), matching populated sections.getChevronDetailsto depend only on visibility.aria-expandedto the account and product toggles.aria-controlsis intentionally omitted for consistency with gitify and to avoid referencing conditionally unmounted content.Testing
pnpm exec tsc --noEmitpnpm exec biome checkon changed filespnpm i18n:check