Repository navigation
Conversation
Contributor
Author
|
@macladson Updated the branch to incorporate PR #10378 fixes that addresses the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Introduces REST-SSZ wire types required for the REST-SSZ engine API implementation based on the spec
Proposed Changes
PR #9652 has the complete implementation of the REST-SSZ engine API and support uptil Gloas but since the diff is 6k+, reviewing such a PR will not be possible and hence I will be creating multiple smaller PRs from PR #9652 as mentioned in this comment to improve reviewability starting with the following PR of adding REST-SSZ wire types.
ssz_structures.rswhich holds the wire containers required for the REST-SSZ engine along with the conversions between those containers and the internal SSZ containers.EncodeandDecodeon existing types that can be reused instead of redeclaring them inssz_structures.rsMaxExecutionRequestsPerPayload,MaxErrorBytesandMaxVersionedHashesPerRequesttypes to theEthSpectrait in accordance with the spec