Repository navigation
Preserve equals signs in CLI keyword values - #1180
Merged
BenjaminBossan merged 2 commits intoOct 26, 2026
Merged
Conversation
BenjaminBossan
requested changes
Oct 26, 2026
BenjaminBossan
left a comment
BenjaminBossan
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this fix, LGTM. Just a comment about the test.
| assert np.isclose(parsed_kwargs['module__nonlin'].upper, 0.456) | ||
|
|
||
| @pytest.mark.parametrize('label', ['epoch', 'epoch=1', 'epoch=1=best']) | ||
| def test_parse_net_kwargs_string_with_equals(self, parse_net_kwargs, label): |
Collaborator
There was a problem hiding this comment.
This case could be easily integrated into the test above, right?
BenjaminBossan
approved these changes
Oct 26, 2026
BenjaminBossan
left a comment
BenjaminBossan
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CLI object argument such as
builtins.dict(label="epoch=1")raisesValueErrorbecause keyword parsing splits on every=. Split only on the first delimiter so the rest of the string stays in the value.Added regression coverage for strings with one or multiple equals signs, alongside a plain-string control. The two regression cases fail before the fix;
pytest skorch/tests/test_cli.pypasses all 45 tests after it.