Skip to content

fix(setup): escape metadata in generated package files - #58

Open
ikenyal wants to merge 1 commit into
strands-agents:mainfrom
ikenyal:fix/setup-metadata-escaping
Open

ikenyal wants to merge 1 commit into
strands-agents:mainfrom
ikenyal:fix/setup-metadata-escaping

Conversation

@ikenyal

@ikenyal ikenyal commented Nov 5, 2026

Copy link
Copy Markdown

Issue #, if available

N/A. Issues are disabled for this repository.

Description of changes

Entering a description such as Tools for "search" in C:\work, or an author name containing quotes, corrupts the generated package metadata. Python reports successful setup with an invalid pyproject.toml; TypeScript fails when cleanup parses the invalid package.json.

Escape replacement values inside those two package files while keeping the existing replacements for source files and READMEs. The existing setup CI now supplies quoted, backslash-containing, and Unicode metadata to both hoist-all runs and asserts that the parsed values match the input. The subset runs retain their ordinary default inputs.

Testing

Verified in disposable copies on macOS arm64, using Python 3.14.8 and Node.js 26.12.0:

  • Confirmed the new metadata inputs fail with the original setup scripts.
  • Both languages: hoist-all with special metadata and the ordinary tool/plugin subset complete successfully; generated metadata matches the input.
  • Python: hatch run prepare passed in both generated layouts (12 and 2 tests), followed by source distribution and wheel builds.
  • TypeScript: npm run check and npm run build passed in both generated layouts (11 and 3 tests).
  • The TypeScript setup script also passed a separate strict type check and Prettier check.
  • Workflow and generated YAML parsed successfully; all 10 setup-workflow shell steps passed Bash syntax checks; git diff --check passed.

Hosted Ubuntu and the full Python/Node version matrix were not run locally. No AWS resources or model calls were used.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ikenyal
ikenyal marked this pull request as ready for review November 5, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant