Repository navigation
Conversation
Owner
|
Huh nice, really makes you think why this isn't upstream default. EDIT: Hang on, you are upstream! Haha. So, how about you make this default? |
Author
|
We didn't decide whether to do it in v4.x yet. But it will for sure be in v5. We're seeing varying scales of speed-ups from 1% to the eye watering 300x improvement seen here depending on setup and benchmark quality. |
Author
|
To be clear, this benchmark are by no means well-crafted, using only a constrained Docker-on-macOS setup, so the speed-ups are probably less than your users will actually see. But plausibly a tiny Linux box on a crappy VPS will benefit most. |
svenstaro
reviewed
Nov 3, 2026
Comment on lines
+272
to
+273
| .tcp_nodelay(true) | ||
| .h1_write_buffer_size(256 * 1024); |
Owner
There was a problem hiding this comment.
Maybe add a tiny comment here as to why?
Owner
|
Please rebase. I just made master happy. |
robjtede
force-pushed
the
perf/connection-tuning
branch
from
November 3, 2026 16:18
1c6de9e to
4539436
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable TCP_NODELAY and a 256 KiB HTTP/1 write buffer. Require Actix Web 4.14.
Trixie ARM64 Docker loopback; median of five 5-second runs. Settings tested separately.