Repository navigation
Destroy the server socket when binding it fails - #164
Merged
svenvc merged 1 commit intoOct 24, 2026
Merged
Conversation
Owner
|
Yes, this is better for sure. Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163.
Socket newTCPhappens before the bind, so whenlistenOn:signals the socket is neither destroyed nor returned, and its three external semaphores stay registered until finalization. Wrapping the attempt inifCurtailed:gives it ownership of the socket, the wayZnMultiThreadedServer>>#serveConnectionsOn:already does for an accepted one. The success path is unchanged.No test here: the leak is only observable through
Smalltalk externalObjectsorSocket allInstances, and finalization reclaims it, so any test is timing-sensitive. Glad to add one in whatever form you prefer.