Repository navigation
Preserve notifications during client connection reuse - #165
Merged
svenvc merged 1 commit intoOct 26, 2026
Merged
Conversation
Gabriel-Darbord
force-pushed
the
fix/client-reuse-notifications
branch
from
October 26, 2026 12:42
adb7211 to
b2417bb
Compare
Owner
|
Interesting ! Looks great to me. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A caller deadline around a request on a reused keep-alive connection can be swallowed:
TimedOutis a Notification, andgetConnectionAndExecutecatches every Exception and starts a fresh request. The call can then return successfully after its caller's deadline. Resumable notifications are also intercepted and needlessly discard the connection.Restrict that recovery handler to Error. Ordinary read/network errors keep the existing fresh-connection fallback; notifications reach the caller and can resume normally. The configured retry exception set and retry count are unchanged.
Add three local-server regressions covering caller cancellation, resumable notification propagation on the same connection, and recovery from an injected read error. The timeout and resumable-notification cases fail with the original handler; all three pass with the fix. The timeout regression uses the portable Duration-based API.