Repository navigation
Print a transfer of unknown size on every supported Pharo - #168
Merged
Merged
Conversation
ZnUtils class>>#signalProgress:total: printed the amount with #humanReadableSIByteSize, which Pharo 11 renamed to #humanReadableSISizeString and Pharo 13 removed, so signalling progress for a body of unknown size failed there. ZnUtils class>>#humanReadableSize: uses whichever of the two the image has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Again, thank you, looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZnUtils class >> #signalProgress:total:prints the amount with#humanReadableSIByteSize. Pharo 11 renamed it to#humanReadableSISizeString, kept the old name as a deprecated alias through Pharo 12, and Pharo 13 removed it. So signalling progress for a body of unknown size fails on Pharo 13 and 14, and is rewritten as a deprecation on 11 and 12. (#167 said no Pharo from 11 on has it; 11 and 12 do, deprecated.)ZnUtils class >> #humanReadableSize:sends whichever of the two the image has, asZnFileSystemUtilsdoes for file streams. Both answer the same strings, in SI units by 1000.ZnUtilsTest >> #testSignalProgressWithoutTotalcovers the branch for an unknown total, which no test reached.