Repository navigation
[BugFix][WS] Decline warp specialization on loop-carried post-pipeline updates #3883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VikingDeng
wants to merge
3
commits into
tile-ai:main
Choose a base branch
from
VikingDeng:fix/3842-ws-loop-carried-postlude
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clone producer-owned storage by data Var, so producer accesses through every alias follow the clone.
maybe_clonedecides cloning by Buffer identity, andRemapBuffersrewrites only the same Buffer object. The producer can read the same storage through another Buffer view, and that read keeps the original storage. The clone and the alias then diverge.The divergence can occur in a guarded producer-only prelude. The prelude writes buffer X, and
producer_accessincludes X through the guard summary.maybe_cloneclones X to X'. The prelude write goes to X', but the producer's reads through view Y still target the original storage, which the prelude did not write. The producer can read stale or uninitialized values.This change makes the case reachable more often. A producer read of only Y can now classify the prelude write to X as producer-only. Before this change, the case required the producer to access X by identity as well. The ownership gap in
maybe_cloneandRemapBufferspredates this change.Ownership must cover every view of the cloned storage. Either rewrite all producer accesses to the storage by data Var, or do not clone storage that the producer also reaches through an alias. Keep the consumer's accesses to that storage consistent with the choice.