Repository navigation
[Docs] Align ROCm source-build prerequisites #4386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
git-jxj
wants to merge
1
commit into
tile-ai:main
Choose a base branch
from
git-jxj:docs/rocm-build-prerequisites-20261116
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Install the build backend with the same
pipthat runs the editable build.Line 275 runs before line 294 puts
/usr/local/binfirst on PATH. Itspiptherefore resolves to/opt/venv/bin/pip. Thepipcalls at lines 302 and 314 resolve through the reordered PATH. If the container has a/usr/local/bin/pipfor a different interpreter, the--no-build-isolationbuild at line 314 may not findscikit-build-core,cmake, orninja. Move the line 275 install after the PATH update so that every build requirement uses the samepip. When/usr/local/bin/pipis absent, thepipresolution is unchanged.Suggested fix
export PATH="$(dirname "$LLVM_CONFIG"):/usr/local/bin:${PATH}" + +# Keep setuptools < 80 (compat with some base images) +pip install --upgrade "setuptools>=77.0.3,<80" wheel cmake ninja scikit-build-core