Repository navigation
Inspect linked model assets and preserve unreadable cache diagnostics - #1098
Draft
dlukeomalley wants to merge 1 commit into
Draft
dlukeomalley wants to merge 1 commit into
dlukeomalley wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doctor skips symlinked cache entries even though normal model resolution loads them. It reports valid shared models missing and recommends downloading them again. The cache lookup also labels unreadable input as invalid content and recommends replacement without having read its header.
Delegate matching
.ggufentry inspection to the existing shared GGUF validator. It now refuses non-regular paths before opening them, which also fixes a reproducible FIFO block in runtime validation. Keep missing, invalid and unreadable outcomes distinct; unreadable paths get an access/path correction rather than a replacement recommendation..etagsidecars remain excluded.Actual CLI controls cover valid, HTML, dangling and directory links. A directly owned worker reproduces the FIFO block with a bounded timeout; ordinary permission failure retains the unreadable/no-header result. No test-only application API or new validator is added.
Validation at f851dc6:
CI-mode model integrations and unsupported Windows/POSIX cases remain skipped. Header fixtures establish inspection behavior, not full model validity or inference quality. Existing filename matching and stat/open race limits remain unchanged.