Repository navigation
Separate named uploads from custom fields - #90
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 99.40% 98.89% -0.51%
==========================================
Files 9 9
Lines 336 363 +27
Branches 38 46 +8
==========================================
+ Hits 334 359 +25
Misses 1 1
- Partials 1 3 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: the shared
fieldsoption serialized named upload IOs into signed JSON and duplicated custom metadata as form fields, coercing typed values or producing bracketed keys.Add
uploads: {name => io}to Assembly options andcreate!. Named files become multipart parts;fieldsstays entirely in signed JSON with its numbers, booleans, arrays, objects, and null intact. Keep positionalfile_Nuploads andcreate!(fields: metadata)overrides. Legacy IO entries infieldscontinue uploading throughout v4 with a deprecation warning and a documented migration path.Preserve original stream positions when retrying rate-limited uploads and raise a clear
IOErrorfor streams that cannot be replayed. Document upload precedence, reserved names, and caller-owned file handles. Add an Unreleased changelog entry; no version bump or release.The repository's Ruby 3.1 test bundle uses JSON 2 for the separate, preexisting MultiJson compatibility issue in #89. The runtime gemspec is unchanged, and compatible JSON 3 applications on newer Rubies remain supported. The README includes the Ruby 3.1 application workaround; #89 remains open for the runtime dependency fix.
Validation:
fef2891is GitHub-verified, with no co-author trailer.git diff --checkpasses.After release, Content can upgrade its pinned gem and generate
assembly(uploads: named_files, fields: metadata).create!, removing the 4.0.0create!(fields: metadata)workaround while retaining binary File handles, cleanup, and the real-gem sweep.Closes #88.
🤖 Claimed by kvz on
framework1/ruby-sdksince 2026-10-18 · resume:codex resume 01a14e1d-ce02-76b1-81f0-5014b90ba94d