Repository navigation
Conversation
dennisbader
approved these changes
Oct 27, 2026
dennisbader
left a comment
dennisbader
left a comment
Collaborator
There was a problem hiding this comment.
Thanks a lot for the nice fix and your first contribution @AryanRG 🚀
Everything looks good to me 💯
I added a reference to the PR in the changelog.
I'll merge once all tests have passed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3304 +/- ##
=======================================
Coverage 97.13% 97.13%
=======================================
Files 175 175
Lines 19411 19411
=======================================
Hits 18855 18855
Misses 556 556 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Fixes #3303.
Summary
Short multivariate or sampled series fail in
MIDAS.fit_transform()because the padding arrays use singleton component and sample dimensions. Preserve those dimensions when creating the padding.Added round-trip regressions for short monthly windows, quarter-start/end labels and multiple components/samples. The transformer and pipeline tests and repository pre-commit checks pass.