Repository navigation
Fix/warn when extracting stochastic TimeSeries values - #3307
Open
Pallav-Biyala wants to merge 4 commits into
Open
Pallav-Biyala wants to merge 4 commits into
Pallav-Biyala wants to merge 4 commits into
Conversation
Signed-off-by: Pallav-Biyala <pallav.biyala@iitgn.ac.in>
Signed-off-by: Pallav-Biyala <pallav.biyala@iitgn.ac.in>
dennisbader
approved these changes
Oct 27, 2026
dennisbader
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix and your first contribution @Pallav-Biyala 🚀
I slightly updated the warning message and tests. Apart from that everything looks great 💯
I'll merge once all tests have passed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3296
Summary
sampleparameter inTimeSeries.values()from0toNoneto distinguish between callers who omit the argument and those who explicitly select a sample.sampleis omitted for a stochastic time series, emit a warning explaining that only sample 0 will be returned and suggestingTimeSeries.mean()orTimeSeries.quantile(0.5)when a point forecast is desired.values()still returns sample 0 by default. Explicitly specifyingsample=0or another sample does not trigger the warning.TimeSeries.to_dataframe(), which already represents samples of a stochastic time series in separate columns.Testing
darts/tests/test_timeseries.py: 329 passed, 1 skipped.git diff --check: passed.