Repository navigation
Symbols: skip tables without producer in verify_table_versions - #2061
Open
cristianchiriac wants to merge 1 commit into
Open
cristianchiriac wants to merge 1 commit into
cristianchiriac wants to merge 1 commit into
Conversation
VmwareLayer adds a NativeTable to the symbol space, and NativeTable has no producer attribute, so verify_table_versions raised AttributeError before reaching the existing 'no producer metadata' branch. Plugins that check the default table list, such as linux.kmsg, failed on every VMware image. Fixes volatilityfoundation#2058
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2058.
VmwareLayerappends aNativeTable("vmware", ...)to the symbol space.NativeTablehas noproducerattribute, soSymbolSpace.verify_table_versionsraisedAttributeError: 'NativeTable' object has no attribute 'producer'ontable.producer, before the existing "no producer metadata" branch could skip it. Any plugin that checks the default table list, such aslinux.kmsg.Kmsg, failed on every VMware image.The method now reads the attribute with
getattr(table, "producer", None), so tables without one take the existing skip branch.test/test_symbol_space.pyadds aNativeTableto a fresh context's symbol space and callsverify_table_versionswith a validator that always fails. Without the change it raises theAttributeErrorfrom the issue; with it the native table is skipped and the call returnsTrue.ruff checkandruff format --checkpass on both files. As far as I can see, the test workflow only runstest/plugins, so this file (liketest_linux_socket_addresses.py) only runs locally.