Repository navigation
Conversation
PLAN writes its lines between begin/end marker lines, after a leading newline, flushing sys.stdout first and writing the bytes to the original standard output, like the environment probe, so that output of a sitecustomize module or a .pth file without a trailing newline no longer glues to the first line of the plan and drops a requirement. The frame parsing of the probe is extracted into framedOutput and reused; a missing frame fails with a PythonDependencyException. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG
…probe (#60) Each plan entry is written as the hex digits of its UTF-8 bytes, so a requirement with a line break, e.g. within its URL, accepted by packaging, or containing the end line of the plan, can no longer split or cut off the plan. The framed writer is one Python snippet, FRAMED_WRITER, shared by the probe and PLAN; it writes to file descriptor 1 directly, so that a sys.stdout or sys.__stdout__ of None no longer crashes it. The output in the message of a missing plan is limited, like the error of the probe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
PLAN's result is no longer parsed from its standard output line by line, where stdout noise without a trailing newline (from a
sitecustomizeor.pthfile) glued to the first entry and dropped it.Nonesys.stdoutdoesn't matter.FRAMED_WRITER, now writes the frame for both the probe and PLAN, and one KotlinframedOutputreads it for both.packaging) no longer splits into a bogus entry, and a requirement containing the end marker no longer cuts the plan short.PythonDependencyExceptionnaming the unexpected output, capped like the probe's (sharedlimitOutput).Review
1 round — no blocking findings. The review's polish was applied before this PR: hex-encoded entries and the
None-stream guard (both fixing pre-existing variants onmain, hence fixed here instead of filed), the shared writer, the message cap, a less brittle failure test, KDoc.Merge note
Independent of the open #70 (#25) and the coming #6 stack, but all of them change the PLAN script: whichever is merged later needs
mainmerged in — expect conflicts at the first and last lines of PLAN (FRAMED_WRITER + """and thewrite_framed(...)call), and inplan()parsing (#6 adds aninstalledentry kind).🤖 Generated with Claude Code
https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG