Repository navigation
Conversation
…75) uv 0.2.30 to 0.5.0 reject its --constraints alias, so every installation with such a uv on the PATH failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG
… applied (#75) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG
…#75) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75
uv pip installnow gets the constraints of the dependency directory with--constraint, accepted by every uv version, instead of--constraints, an alias only since uv 0.5.4 — so with uv 0.2.x–0.5.3 on thePATHevery dependency install failed withunexpected argument '--constraints' found.--target/--constraint/ dependency arguments are built once and shared by the uv and pip commands, so they can't drift apart again; the pip command is unchanged.uvscript recording its arguments (runs everywhere but Windows, also in CI); two real-uv tests, skipped without uv on thePATH, installing a locally built wheel — one satisfying the constraint, one violating it (failing with the constraint named), so the constraint is proven applied, not just accepted.--rerun --no-daemonwith each on thePATH).Squash note: the first commit's subject says "before 0.5.1" — the alias actually appeared in 0.5.4 (bisected during the review); please reword when squashing.
Review
2 rounds: 1st — only blocking item was the wrong version in comments (fixed); 2nd — no blocking findings. Polish applied: shared arguments, violating-constraint test tied to the constraint.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG