Skip to content

Pin the imported_files rule by tests, cache top-level modules, fix comments (#90) - #95

Open
morisil wants to merge 1 commit into
issue-81-satisfied-requirementsfrom
issue-90-polish-79
Open

morisil wants to merge 1 commit into
issue-81-satisfied-requirementsfrom
issue-90-polish-79

Conversation

@morisil

@morisil morisil commented Nov 13, 2026

Copy link
Copy Markdown
Member

Fixes #90

Stacked on #92 (fix of #81) → #91 (#79) → #82 (#59) → #70 (#25) — merge #70, #82, #91, #92, then this one (bottom-up, see CLAUDE.md).

Polish left after the 3rd review round of #79:

  • Two tests pin the changed imported_files rule — a top-level demo.pth/demo.pyi is no file of the demo module, and demo.libs/ counts for demo (vendored=True); reverting either rule fails its test (checked).
  • The top_level_name comment says auditwheel names X.libs/ after the distribution, not the module.
  • is_imported keeps the top-level modules of each dist-info of the run (dist_info_top_levels), instead of re-parsing every RECORD on every call.
  • The test helper extensionSuffix uses runProcess(pythonCommand(...)) — its waitFor(5, MINUTES) after a blocking readLine() could never fire.
  • The writeDistInfo comment no longer refers to packages_distributions.

Review

1 round, no blocking findings. Left as polish: one test comment ("after 1.0 removed them") reads misleadingly; runProcess has no timeout at all; top_level(distribution) is still read once uncached. Pre-existing, noted: vendored .libs matching is case-sensitive (Shapely.libs/ never counts for shapely), and the constraint loop de-duplicates by the raw Name (two spellings of one name can each be constrained — the blocked branch of #89 keys by normalized name).

🤖 Generated with Claude Code

https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG

…ules per dist-info (#90)

- test that top-level .pth and .pyi files named like an imported module are not its files,
  and that the auditwheel demo.libs/ directory counts as files of demo
- correct the top_level_name comment: auditwheel names X.libs/ after the distribution
- tell the top-level modules of each dist-info of the dependency directory once in is_imported
- extensionSuffix of the test runs Python through runProcess(pythonCommand(...))
- the writeDistInfo comment no longer refers to packages_distributions

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant