Repository navigation
Conversation
…ules per dist-info (#90) - test that top-level .pth and .pyi files named like an imported module are not its files, and that the auditwheel demo.libs/ directory counts as files of demo - correct the top_level_name comment: auditwheel names X.libs/ after the distribution - tell the top-level modules of each dist-info of the dependency directory once in is_imported - extensionSuffix of the test runs Python through runProcess(pythonCommand(...)) - the writeDistInfo comment no longer refers to packages_distributions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90
Stacked on #92 (fix of #81) → #91 (#79) → #82 (#59) → #70 (#25) — merge #70, #82, #91, #92, then this one (bottom-up, see CLAUDE.md).
Polish left after the 3rd review round of #79:
imported_filesrule — a top-leveldemo.pth/demo.pyiis no file of thedemomodule, anddemo.libs/counts fordemo(vendored=True); reverting either rule fails its test (checked).top_level_namecomment says auditwheel namesX.libs/after the distribution, not the module.is_importedkeeps the top-level modules of each dist-info of the run (dist_info_top_levels), instead of re-parsing everyRECORDon every call.extensionSuffixusesrunProcess(pythonCommand(...))— itswaitFor(5, MINUTES)after a blockingreadLine()could never fire.writeDistInfocomment no longer refers topackages_distributions.Review
1 round, no blocking findings. Left as polish: one test comment ("after 1.0 removed them") reads misleadingly;
runProcesshas no timeout at all;top_level(distribution)is still read once uncached. Pre-existing, noted: vendored.libsmatching is case-sensitive (Shapely.libs/never counts forshapely), and the constraint loop de-duplicates by the rawName(two spellings of one name can each be constrained — the blocked branch of #89 keys by normalized name).🤖 Generated with Claude Code
https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG