Repository navigation
fix(lido): link governance votes and clarify alert heading - #423
Merged
Merged
Conversation
Fix P2 metadata escaping and preserve a bounded description preview without cutting Markdown escape pairs. Fix P3 empty vote ID headers, correct the Aragon Voting contract label, and render the README example from the formatter. Record the three confirmed bugs as triaged. Defer P4 heading mappings and shared governance ID formatting: those refactors are optional and would broaden the Lido-specific change. Validation: 51 relevant tests and 20 subtests pass. Ruff, formatting, ty, and the dependency audit pass. Regression tests fail before the fixes and detect an intentionally broken escape-boundary guard.
spalen0
marked this pull request as ready for review
October 14, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lido
StartVotealerts currently say "New Operation Scheduled" and provide only a vote number. Use "New Governance Vote", label the contract "Lido Aragon Voting", and link directly tohttps://dao.lido.fi/vote/<voteId>. Keep the vote ID and link in the header so they survive long metadata; omit both when the ID is absent, while supporting vote zero.Escape creator-supplied metadata as literal Telegram Markdown text and retain a preview within the remaining message budget, with a truncation marker. Do not split a Markdown escape pair at the preview boundary. Retain creator and transaction links. Update the monitoring metadata, Lido README, and a formatter-generated alert example; record the confirmed bugs as triaged.
Validation:
prek run --all-filespassed: Ruff lint, formatting, and ty checks.uv audit --preview-features audit-commandfound no known vulnerabilities or adverse project statuses in 80 packages.