Repository navigation
Conversation
…cket close Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1116
BkBasicalready caps the body byContent-Length, but a chunked body was still the raw socket stream, soread()blocked after the last chunk until the client gave up. The body is now decoded withRqChunkas well, and an unread chunked body is drained before the next request on the connection.The new test sends a chunked request, keeps the socket open, and fails with a read timeout without the change.
Smell, left alone:
ChunkedInputStreamdoes not consume the CRLF after the last chunk, so a keep-alive connection sees it as the start of the next request.🤖 Generated with Claude Code