Repository navigation
Conversation
…ream and RqSocket (solves yegor256#1749) Signed-off-by: Inf1mum <vadim.lazuk@mail.ru>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request solves #1749
This is a javadoc-only revision of the files listed in the revive-code-bot checklist for the
org.takes.miscpackage plus the twoorg.takes.rqfiles from the same checklist. No code behavior is changed and no duplicate tests are added (the existing suites already cover the behavior).What exactly is documented
org.takes.misc.VerboseIterator— per-method contracts:next()throwsNoSuchElementExceptionwith the ctor-supplied message when the iterator is exhausted; the ctor message is rendered lazily, only when the exception is actually thrown;remove()is always unsupported (UnsupportedOperationException).org.takes.misc.VerboseIterable—iterator()returns a freshVerboseIteratoron every call (repeated/concurrent iterations are independent, provided the wrapped iterable produces independent iterators), all of them carrying the same error message.org.takes.rq.TempInputStream—close()contract: the temp file is deleted even if closing the wrapped stream fails, but a deletion failure replaces the stream's exception (deletion runs infinally); the file is deleted only while it still exists, so repeatedclose()is safe with respect to the file; read operations delegate to the wrapped stream, so their behavior afterclose()is determined by that stream.org.takes.rq.RqSocket— all four accessors: documented that a missingX-Takes-*header fails withHttpException(HTTP 400), that port headers are parsed as integers (NumberFormatExceptionfor invalid values), and that address headers are resolved viaInetAddress.getByName(literal IP is used as is, a host name would trigger a DNS lookup; normally the header carries a literal IP set by the server layer).Reviewed without changes
org.takes.misc.package-info.java— the package overview already lists every class currently present in the package (Equality,Expires,Href,Opt,VerboseIterable,VerboseIterator,VerboseList); nothing to fix.VerifiableIterablenamed in the original analysis does not exist on master and never appears in this repository's history — nothing to review.The
facetspackage-infofiles from the same checklist (ret, previous, hamcrest, forward, fork) are intentionally left out of this focused PR.Verified
mvn test -Dtest='TempInputStreamTest,RqSocketTest,VerboseIterableTest,VerboseIteratorTest'— 18 tests, all green.mvn clean install -Pqulice— BUILD SUCCESS (javadoc/Qulice checks pass).