Repository navigation
Maintenance: correct the password policy defaults - #1375
Merged
Merged
Conversation
The three defaults on the password page were documented as they were before commit f63577633f changed them, so a fresh install now disagrees with the page on every one of them. Claim -> source anchor (zammad origin/develop @ c3579d34d9): - Maximum failed logins defaults to 5, not 10 db/seeds/settings.rb:2354 (password_max_login_failed, state: 5) - 2 lower case and 2 upper case characters defaults to yes, not no db/seeds/settings.rb:2263 (password_min_2_lower_2_upper_characters, state: true) - Minimum length defaults to 10, not 6 db/seeds/settings.rb:2237 (password_min_size, state: 10) The ranges in the surrounding prose still match the seed option lists (password_min_size 4-20, password_max_login_failed 4-20). The other two defaults on the page (digit required yes, special character required no) are unchanged and were re-checked against db/seeds/settings.rb:2289,2315.
ArtifactsProduced during runtime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three defaults on the password page were documented as they were before commit f63577633f changed them, so a fresh install now disagrees with the page on every one of them.
Claim -> source anchor (zammad origin/develop @ c3579d34d9):
The ranges in the surrounding prose still match the seed option lists (password_min_size 4-20, password_max_login_failed 4-20). The other two defaults on the page (digit required yes, special character required no) are unchanged and were re-checked against db/seeds/settings.rb:2289,2315.