Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
zmqhas 100% public type coverage, we should probably ensure that it stays that way :)This adds a pre-commit hook that runs
pyrefly coverage check --public-only, which will fail if type coverage falls below 100% (docs).I excluded
zmq/tests/, because it didn't look to me like it was intended to be public API. But if you want it typed regardless, then I'd be happy to work on that :)There's no official
pyrefly coveragepre-commit hook yet, so this uses a local hook for the time being.FWIW: we've been using
pyrefly coverage checkfor a while now in NumPy, and it has been smooth sailing so far.