Repository navigation
Conversation
Each connected login shows its picture, name and status, with Disconnect behind a confirm that says what happens to its chats, and Reconnect when it needs it. Connect another runs the device flow beside the list, and says so when GitHub approved a login that was already connected. Once there is more than one login, each repository says whose it is. An engine or vault from before several logins lists none: the one login it names is shown, and Disconnect means all of GitHub, as it did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wingleeio
force-pushed
the
zeron/zgx-github-accounts
branch
from
November 7, 2026 04:14
2aa5ac7 to
d36627d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings → Cloud for several GitHub accounts. The vault, edge and engine side is #1258; this works without it.
What's on the screen
Strings are in
en.jsonandzh-Hans.json. The logic sits inaccount/github.luauand the view inscreens/settings/cloud.luau. It usesds.Settings,ds.Avatar,ds.Badge,ds.Calloutandds.Dialog, so it should be easy to restyle.With an older engine or vault
GithubAccountsfailing (an engine without it) or listing nothing leaves the one login the status names. It shows as a single row, and Disconnect means all of GitHub, as it does today. Tested withcloud_stub.old_host. Repository fields that an older vault doesn't send read as nil.GitHubBlockand onboarding are unchanged. The block still handles connecting, and shows when there are no logins or while a flow is under way.Not on this screen
Picking which login new chats try first. #1258 has the RPC (
GithubAccountActivate) but I left the control out to keep this simple. Until then, the most recently connected login comes first.Rebased onto
main. A test merge with #1254 (also onmain) conflicts only in the header comment at the top ofaccount/cloud.luauandscreens/settings/cloud.luau, where both PRs describe what they add. No code conflicts; resolving means keeping both descriptions.Tests
cloud_github_accounts.test.luauapps/zgx/uisuitecloud::tests,github::disconnect_tests)cargo check --testsinapps/zgxzgx linton the edited filesThe two failures are About-page tests,
link_menusandsettings_in_place. Both fail the same way on cleanmain. I also looked at the page in a fixture window, using a private data dir.zgx check(type checking) was not run:luau-lspisn't installed here.Still to check
github.com/{login}.pngin the app. Test hosts have no fetcher, so the fixture showed the generated stand-in.🤖 Generated with Claude Code