Repository navigation
fix(eic): mark samples whose EICs missed a tolerance change - #215
Closed
Jack-Coutts wants to merge 4 commits into
Closed
Jack-Coutts wants to merge 4 commits into
Jack-Coutts wants to merge 4 commits into
Conversation
A sample whose CDF was missing at a tolerance change kept old-tolerance EICs that were plotted and exported unmarked next to rebuilt samples. Flag it in the sample list, tile captions, workbook fill and changelog. Refs #206
The unlabelled Qualifier QC sheet kept outcome colours for stale samples, so a green Pass sat beside gold Raw Values and Abundances cells. Gold now wins there too; the outcome text stays readable. Refs #206
This was referenced Nov 10, 2026
Collaborator
Author
|
Replaced by #310, which re-applies this fix onto main after the UI redesign. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Samples whose CDF is missing keep old-tolerance EICs in the export.
A sample whose CDF was missing at a tolerance change kept old-tolerance EICs that were plotted and exported unmarked next to rebuilt samples. Flag it in the sample list, tile captions, workbook fill and changelog.
What changed
Scope
Verification
uv run pytest: the full suite passes, except the offscreen-font test intests/test_toolbar_pills.py, which also fails on main.src/reverted to its base.Closes #206