Repository navigation
fix(integration): key range bounds by each EIC's sample name - #237
Closed
Jack-Coutts wants to merge 6 commits into
Closed
Jack-Coutts wants to merge 6 commits into
Jack-Coutts wants to merge 6 commits into
Conversation
read_eics_batch omits samples with no EIC, so pairing by position stored bounds under the wrong sample and left the last one without any. Refs #188
A sample whose EIC disappeared kept bounds from an earlier visit, so the reload checks skipped it. Clear every requested pair first, which also covers the empty-result and error paths. Refs #188
…ting Selecting one sample whose EIC disappeared kept bounds from an earlier visit, so Apply saved offsets without requesting extraction. Refs #188
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Integration window stores data bounds under the wrong sample.
read_eics_batch omits samples with no EIC, so pairing by position stored bounds under the wrong sample and left the last one without any.
What changed
Scope
Verification
uv run pytest: the full suite passes, except the offscreen-font test intests/test_toolbar_pills.py, which also fails on main.src/reverted to its base.Closes #188