Repository navigation
test: pin #240 fail-fast timing with real encode/httpx rows - #257
Merged
Merged
Conversation
Fixture from encode/httpx#3796 (run 37009481166): the failing matrix row started before every cancelled sibling completed, so vigilar emits ci-roja and rebote bounces it instead of asking for a rerun. Refs #256 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#240's assumption holds on real GitHub data: in a default
fail-fastmatrix, every sibling GitHub cancelled has acompletedAtlater than the failing job'sstartedAt. Two tests now pin those real rows, sovigilarandrebotekeep reporting the failure. No source change.Source (read-only
gh pr view https://github.com/encode/httpx/pull/3796 --json statusCheckRollup): PR encode/httpx#3796, run37009481166(workflowTest Suite, matrix with nofail-fastkey, so GitHub's defaulttrue, checked on the run's head7aee79f4).Earliest cancelled
completedAt(12:54:36) is later than the failure'sstartedAt(12:53:52): the failure is classified as real. The same shape showed in the jobs of three more httpx runs read withgh run view <id> -R encode/httpx --json jobs(35071320524,22379030162,22365498386): in each, the earliest cancelled job completed after the failing job started. They are context only; the fixture uses PR #3796.Evidencia
gh pr view 3796 -R encode/httpx --json statusCheckRollupvigilar)test/vigilar.test.mjs›Issue 256 Rule 2: real fail-fast rows emit ci-roja with the failing row✔ Issue 256 Rule 2: real fail-fast rows emit ci-roja with the failing rowrebote)test/despacho.test.mjs›Issue 256 Rule 2: rebote bounces real fail-fast rows as a failed check instead of asking for gh run rerun✔ Issue 256 Rule 2: rebote bounces real fail-fast rows as a failed check instead of asking for gh run rerunsrc/checks.mjsreverted to[](local mutant, not committed)✖; restored file, both✔src/checks.mjsis unchangedIssue 240 Rule 2: red row started after first cancellation completed is not reported and emits ci-canceladaandIssue 240 PRESERVE: reboteCommand retains rerun refusal when cancellation has no real failure(run38843085964, 02:58:16 / 02:59:09)✔npm run verify:ℹ tests 703,ℹ pass 703,ℹ fail 0; mods suites 0 failTouched public entries: none touched (tests only).
Merge Danger
Two-way door. Tests only; blast radius is the test suite.
Desvíos del ticket
ninguno
Implementador: claude
Closes #256
🤖 Generated with Claude Code