Skip to content

test: pin #240 fail-fast timing with real encode/httpx rows #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gagaismo merged 1 commit into from
Oct 17, 2026
Merged

test: pin #240 fail-fast timing with real encode/httpx rows #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions test/despacho.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,6 +1513,29 @@ describe('rebote', () => {
})
})

test('Issue 256 Rule 2: rebote bounces real fail-fast rows as a failed check instead of asking for gh run rerun', async () => {
// Real statusCheckRollup rows of https://github.com/encode/httpx/pull/3796 (run 37009481166, default fail-fast matrix).
const row = (name, conclusion, startedAt, completedAt, job) => ({
__typename: 'CheckRun', name, workflowName: 'Test Suite', status: 'COMPLETED', conclusion, startedAt, completedAt,
detailsUrl: `https://github.com/encode/httpx/actions/runs/37009481166/job/${job}`,
})
const checks = [
row('Python 3.10', 'CANCELLED', '2026-10-02T12:54:17Z', '2026-10-02T12:55:11Z', 110845502632),
row('Python 3.11', 'CANCELLED', '2026-10-02T12:53:52Z', '2026-10-02T12:54:36Z', 110845502341),
row('Python 3.12', 'FAILURE', '2026-10-02T12:53:52Z', '2026-10-02T12:54:34Z', 110845502631),
row('Python 3.13', 'CANCELLED', '2026-10-02T12:53:54Z', '2026-10-02T12:54:56Z', 110845502533),
]
const env = bounceEnv(pr({ reviews: [], statusCheckRollup: checks }), { 'gh run': json([]) })
await reboteCommand({}, '12', env.io)
const brief = env.written.find(([file]) => file.endsWith('proj-pr-12-rebote.md'))?.[1]
assert.match(brief, /Python 3\.12/)
assert.match(brief, /https:\/\/github\.com\/encode\/httpx\/actions\/runs\/37009481166\/job\/110845502631/)
assert.match(brief, /gh run view --job 110845502631 --log-failed/)
assert.match(brief, /Cancelled siblings.*Python 3\.10, Python 3\.11, Python 3\.13/)
assert.doesNotMatch(brief, /gh run rerun/)
assert.equal(env.written.find(([file]) => file.endsWith('-comment.md'))?.[1], 'Rebote CI: abc123\n')
})

test('Issue 225 PRESERVE: reboteCommand retains existing arguments, refusals and Rebote CI counters', async () => {
const closed = bounceEnv(pr({ state: 'CLOSED' }))
await assert.rejects(reboteCommand({}, '12', closed.io), /no se puede rebotar/)
Expand Down
21 changes: 21 additions & 0 deletions test/vigilar.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,4 +924,25 @@ describe('orca-stack vigilar (#206)', () => {
await once(pending, ['7'])
assert.deepEqual(pending.out, ['pr-abierto #7 PR #70 abc1234'])
})

test('Issue 256 Rule 2: real fail-fast rows emit ci-roja with the failing row', async () => {
// Real statusCheckRollup rows of https://github.com/encode/httpx/pull/3796 (run 37009481166, default fail-fast matrix).
const row = (name, conclusion, startedAt, completedAt, job) => ({
__typename: 'CheckRun', name, workflowName: 'Test Suite', status: 'COMPLETED', conclusion, startedAt, completedAt,
detailsUrl: `https://github.com/encode/httpx/actions/runs/37009481166/job/${job}`,
})
const checks = [
row('Python 3.10', 'CANCELLED', '2026-10-02T12:54:17Z', '2026-10-02T12:55:11Z', 110845502632),
row('Python 3.11', 'CANCELLED', '2026-10-02T12:53:52Z', '2026-10-02T12:54:36Z', 110845502341),
row('Python 3.12', 'FAILURE', '2026-10-02T12:53:52Z', '2026-10-02T12:54:34Z', 110845502631),
row('Python 3.13', 'CANCELLED', '2026-10-02T12:53:54Z', '2026-10-02T12:54:56Z', 110845502533),
]
const h = harness({ prs: [pr(70, { checks })], runs: [] })
await once(h, ['7'])
assert.deepEqual(h.out, [
'pr-abierto #7 PR #70 abc1234',
'ci-roja #7 PR #70 abc1234: Python 3.12=FAILURE',
])
assert.equal(h.cursor()['7'].ci, 'roja')
})
})
Loading