Repository navigation
Migrate packaging from setup.py to pyproject.toml - #82
Merged
Merged
Conversation
kohlerca
reviewed
Aug 31, 2026
kohlerca
approved these changes
Sep 2, 2026
kohlerca
left a comment
kohlerca
left a comment
Contributor
There was a problem hiding this comment.
The changes look good to me.
1 task done
CozySocksAlways
added a commit
that referenced
this pull request
Sep 15, 2026
* Fix deprecated plt.cm.get_cmap in plot_patterns (#81) * Replaced depricated plt.cm.get_cmap api * Switched to newer API for getting colormap * Apply suggestions from code review Co-authored-by: Michael Denker <m.denker@fz-juelich.de> * Bumbed matplotlib min version to allign with api change --------- Co-authored-by: Michael Denker <m.denker@fz-juelich.de> * Migrate packaging from setup.py to pyproject.toml (#82) * Swapped out setup.py with pyproject.toml * Adding a architectural decision record file * Splitup into multiple adrs * upper limit on setuptooks for python 3.8 support; ADR changes * remove newer licence field from pyproject.toml since older setuptools doesn't understand it * Added statement to exclude adrs from packaging * Reinstated licence classifier as per PR review * refactorted and updated CI workflow file * Switched to major version only for github actions; major.minor version is not supported * Updated pip install commands to have necessary packages to run unit tests * Fix for silent failure in unitary event analysis doc build, swapped out np.stack with list comprehension in doc strings example --------- Co-authored-by: Michael Denker <m.denker@fz-juelich.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary
setup.pywithpyproject.toml, using thesetuptoolsbuild backendrequirements/*.txtas the single source of truth for dependencies, wired in as dynamic fieldspackagesfieldsetuptools >= 69.0, < 75.4(not the newer>=77.0) to keep this a patch release: setuptools 77.0 requires Python >=3.9, which would break installs on the still-supported Python 3.8 (see ADR 3)license = {file = "LICENSE.txt"}table form instead of an SPDXlicensestring +license-files, since PEP 639 support only lands in setuptools 77.0doc/adr/Notes