Skip to content

Override minimatch to 11.0.1 for GHSA-g3hv-75wg-m249 - #36

Merged
ahmershahdev merged 1 commit into
mainfrom
fix/minimatch-advisory
Nov 2, 2026
Merged

ahmershahdev merged 1 commit into
mainfrom
fix/minimatch-advisory

Conversation

@ahmershahdev

@ahmershahdev ahmershahdev commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Dev tooling only (ESLint, typescript-eslint, Redocly). npm overrides pin minimatch 11.0.1; lint, typecheck, tests, build and api-types pass and the generated schema is unchanged.

Summary by CodeRabbit

  • Documentation
    • Updated the known issues list, removing an outdated advisory note and its related guidance. This keeps the documented issue status current and avoids presenting the former recommendation as still applicable.

@ahmershahdev
ahmershahdev enabled auto-merge (squash) November 2, 2026 12:42
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between d8af6b8 and 12801c6.

Files ignored due to path filters: 1
  • frontend/package-lock.json is excluded by !**/package-lock.json, !**/package-lock.json
Files selected for processing: 2
  • docs/status.md
  • frontend/package.json
Files with no reviewable changes: 1
  • docs/status.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

The frontend package manifest now overrides minimatch to version 11.0.1. The status page no longer lists the related advisory, downgrade suggestion, or upstream-fix note.

Changes: minimatch update

Layer / File(s) Summary
Pin minimatch and update status
frontend/package.json, docs/status.md
frontend/package.json overrides minimatch to 11.0.1. docs/status.md removes the known-issues entry about the advisory and suggested workaround.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: Minimal · up to 12801

The advisory-related dependency is updated, and no failure in the current workflow is established. Mergeable after normal checks.

Architecture risk: Low · up to 12801

The change affects 2 systems.

Changed systems: docs, frontend

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 1 changed file maps to changed impact.
  • observed — frontend (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/status.md: Removed the Known issues entry describing the moderate minimatch advisory in ESLint and openapi-typescript, the suggested TypeScript ESLint downgrade, and the note to wait for an upstream fix.
  • observed — Modified behavior in frontend/package.json: Adds an overrides entry that sets minimatch to version 11.0.1.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: adding a minimatch 11.0.1 override to address GHSA-g3hv-75wg-m249.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

@ahmershahdev
ahmershahdev merged commit dfc2007 into main Nov 2, 2026
7 checks passed
@ahmershahdev
ahmershahdev deleted the fix/minimatch-advisory branch November 2, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant