Repository navigation
Conversation
987d562 to
7dc241e
Compare
There was a problem hiding this comment.
Nice work! cached_get_dag is keyed on the DagRun object rather than the Dag, so every candidate was a genuine miss with 3 get_dag_for_run calls down to 1 on your test.
One note: the two if active_runs >= max_active_runs log branches are nearly dead after this. get_queued_dag_runs_to_set_running already drops runs for Dags sitting at their limit, so they only fired when the limit filled mid-loop, which your new marking short-circuits. On your scenario main logs twice and this PR logs nothing. Worth either moving that line to where you mark the key, or dropping the branches.
Also, the backfill path got the same marking and has no test.
7dc241e to
13a9fab
Compare
|
Thanks, good catch. :D I also added a backfill regression test for the same pruning behavior. |
13a9fab to
807b4fa
Compare
|
Hello @fat-catTW - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 17 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Why:
When
_start_queued_dagruns()processes queued DagRun candidates, one candidate can fill the remainingmax_active_runscapacity for a Dag or backfill. The scheduler already knows later candidates for the same(dag_id, backfill_id)cannot start in the same pass, but it still loaded the serialized Dag and re-checked the same limit for each one.Solution:
Remember
(dag_id, backfill_id)keys that reach their active run limit during the scheduler pass. Later queued DagRun candidates for the same key are skipped immediately, avoiding repeated serialized Dag loads and duplicate limit checks while preserving the existingmax_active_runsbehavior.Was generative AI tooling used to co-author this PR?
[X]Yes (please specify the tool below)Generated-by: [Codex] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.