Skip to content

Respect SMTP connection sender for task email alerts - #72561

Closed
fat-catTW wants to merge 3 commits into
apache:mainfrom
fat-catTW:fix-smtp-from-email-precedence-69262
Closed

fat-catTW wants to merge 3 commits into
apache:mainfrom
fat-catTW:fix-smtp-from-email-precedence-69262

Conversation

@fat-catTW

Copy link
Copy Markdown
Contributor

Why

Automatic task failure and retry email notifications were resolving from_email from [email] from_email before creating the default SMTP notifier. That meant the SMTP connection's more specific from_email setting could never be used, because SmtpNotifier only reads the connection value when from_email is None.

This caused task alert emails to ignore sender addresses configured on the SMTP connection.

relates: #69262

Solution

Let the default SMTP notifier receive from_email=None from the task runner, so it can resolve the sender in the intended order:

  1. SMTP connection from_email
  2. [email] from_email
  3. airflow@airflow

The legacy custom [email] email_backend path continues to receive the configured sender directly, preserving its existing behavior.

Was generative AI tooling used to co-author this PR?
  • [X] Yes (please specify the tool below)

Generated-by: [Codex] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @fat-catTW - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 17 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers area:task-sdk closed because of open PR limit Closed as a one-time step of introducing the open pull request limit provider:smtp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants