Repository navigation
fix: correct error messages in NewRelic, Dynatrace, and Stackdriver providers - #1986
Open
okarin1511 wants to merge 1 commit into
Open
okarin1511 wants to merge 1 commit into
okarin1511 wants to merge 1 commit into
Conversation
…roviders NewRelic and Dynatrace providers wrap a nil error with %w on non-200 responses. At that point err is nil (from the successful io.ReadAll call), producing messages like "error response: <body>: <nil>". Changed to format the HTTP status instead. Stackdriver provider builds a detailed gRPC error string with status details but then formats the original error instead of the constructed string. Changed to use errStr in the gRPC status branch. Signed-off-by: Aseem Khandekar <69676297+okarin1511@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1985
Summary
RunQuerywraps a nilerrwith%won non-200 responses (theerrvariable holds the result of a successfulio.ReadAll, not the HTTP error). Changed to formatr.Statusinstead.RunQueryconstructs a detailed gRPC error string (errStr) with status message and details, then formats the originalerrinstead. Changed to useerrStrin the gRPC status branch.Test plan