Skip to content

fix: correct error messages in NewRelic, Dynatrace, and Stackdriver providers #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okarin1511 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct error messages in NewRelic, Dynatrace, and Stackdriver providers #1986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/metrics/providers/dynatrace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func (p *DynatraceProvider) RunQuery(query string) (float64, error) {
}

if r.StatusCode != http.StatusOK {
return 0, fmt.Errorf("error response: %s: %w", string(b), err)
return 0, fmt.Errorf("error response: %s: %s", string(b), r.Status)
}

var res dynatraceResponse
Expand Down
2 changes: 1 addition & 1 deletion pkg/metrics/providers/newrelic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func (p *NewRelicProvider) RunQuery(query string) (float64, error) {
}

if r.StatusCode != http.StatusOK {
return 0, fmt.Errorf("error response: %s: %w", string(b), err)
return 0, fmt.Errorf("error response: %s: %s", string(b), r.Status)
}

var res newRelicResponse
Expand Down
2 changes: 1 addition & 1 deletion pkg/metrics/providers/stackdriver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func (s *StackDriverProvider) RunQuery(query string) (float64, error) {
errStr = errStr + " Error Detail: " + d.String()
}

return 0, fmt.Errorf("error requesting stackdriver: %s", err)
return 0, fmt.Errorf("error requesting stackdriver: %s", errStr)
}
return 0, fmt.Errorf("error requesting stackdriver: %s", err)
}
Expand Down