Skip to content

Test service enumeration and single-service cache stability - #1963

Merged
oznetmaster merged 1 commit into
nunit:mainfrom
oznetmaster:fix/adopt-api-beta1013-20261112
Nov 15, 2026
Merged

oznetmaster merged 1 commit into
nunit:mainfrom
oznetmaster:fix/adopt-api-beta1013-20261112

Conversation

@oznetmaster

@oznetmaster oznetmaster commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Adds five regression cases for service enumeration through the public service locator and its registered service manager. They check unknown types, ordinary started services, multiple/assignable registrations and preservation of the cached single-service lookup.

After #1964 merged, main 936ca1b already implements the enumeration contract and pins NUnit.Engine.Api beta.101.4, as requested in review. This refresh therefore retains only the two test files and removes this PR's duplicate production implementation and obsolete beta.101.3 pin. It does not change any production source, dependency, provider registration, workflow or public API.

Fresh Windows validation:

  • net462 Required: 418 passed, zero failed, 19 existing skips.
  • net10.0 Required: 410 passed, zero failed, 19 existing skips.
  • All five added cases pass on both targets.
  • Release build: zero warnings/errors under the existing C#13/signing/analyzer rules. Diff whitespace check passes.

These are current-main Windows results. Previous package and native evidence remains in the discussion; this test-only refresh does not claim a new full Package or native execution run. All earlier failed results remain preserved.

Prepared by Neil Colvin with assistance from OpenAI Codex. Keep as a draft; no merge until agreement with Charlie.

@CharliePoole CharliePoole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Tests! Ready to merge with the specified change to beta-101.4.

Comment thread Directory.Packages.props Outdated
<PackageVersion Include="NUnit.Analyzers" Version="4.15.0" />
<PackageVersion Include="NUnit.Agent.Core" Version="4.0.0-beta.6.2" />
<PackageVersion Include="NUnit.Engine.Api" Version="4.0.0-beta.101.2" />
<PackageVersion Include="NUnit.Engine.Api" Version="4.0.0-beta.101.3" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should now be 101.4 after merge of #1964.

Retain the five API and service-registry regressions from nunit#1963 on current main,
which already implements service enumeration and pins API beta.101.4 after nunit#1964.
No production source or dependency change is needed.

Co-authored-by: OpenAI Codex <codex@openai.com>
@oznetmaster
oznetmaster force-pushed the fix/adopt-api-beta1013-20261112 branch from 96a74b0 to b969f45 Compare November 15, 2026 18:07
@oznetmaster oznetmaster changed the title Adopt API beta.101.3 service enumeration Test service enumeration and single-service cache stability Nov 15, 2026

Copy link
Copy Markdown
Collaborator Author

@CharliePoole, thank you. Main now already has API beta.101.4 and the enumeration implementation from #1964, so this refresh keeps just the five test cases you reviewed. The duplicate production changes and older dependency pin are removed from this PR's diff.

On the refreshed current-main source, the required suites pass: net462 418 passed/19 existing skips; net10.0 410 passed/19 existing skips; zero failures. All five added cases pass on each runtime, with zero build warnings/errors.

The PR remains a draft and we have not merged it pending our agreement.

Neil Colvin, with assistance from OpenAI Codex.

@CharliePoole

Copy link
Copy Markdown
Member

@oznetmaster As far as I'm concerned, merging is fine now that #1964 is done. The addition of local changes for either the in-process or remote provider should not affect the overall coordination structure, so we're relatively safe there.

I guess I should send something out to everyone else about that!

@oznetmaster
oznetmaster marked this pull request as ready for review November 15, 2026 22:41
@oznetmaster
oznetmaster merged commit 499100c into nunit:main Nov 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants