Skip to content

Adapt agent lifecycle tests to registered provider services - #1965

Merged
oznetmaster merged 1 commit into
nunit:mainfrom
oznetmaster:test/registered-provider-regressions-20261113
Nov 15, 2026
Merged

oznetmaster merged 1 commit into
nunit:mainfrom
oznetmaster:test/registered-provider-regressions-20261113

Conversation

@oznetmaster

@oznetmaster oznetmaster commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Adapts the disabled ownership, exit and local-release regressions to the registered providers introduced by #1964. Refreshed on main 499100c after #1963 and #1969; the comparison contains only six test-assembly files.

Providers and coordinator use ServiceContext startup/shutdown. Originating-provider return, reference identity, concurrent release, failed-release retry, runner disposal and native cleanup checks remain. The helper providers implement API beta.101.4's AgentExited contract. Production code, dependency pins, classifications and existing ignores are unchanged.

The fixtures run in the normal NUnit suite. Program.cs now explains why native-exit probes and provider servers use child processes: an unhandled callback must fail one probe rather than terminate the parent suite, and connection-loss/stdin-EOF tests require a real process boundary. These are helper modes, not separate test suites.

Validation of the exact refreshed source on Windows:

  • Release build: zero warnings and errors; repository C#13, signing and analyzers retained.
  • Required net462: 479 passed, zero failed, 19 existing skips.
  • Required net10.0: 471 passed, zero failed, 19 existing skips.
  • Diff whitespace check passes. No production workaround or new test exclusion.

Earlier failed receipts are preserved. These are fresh Windows results, not a new native/processor matrix. The separately prepared callback-locking change is outside this diff.

Prepared by Neil Colvin with assistance from OpenAI Codex.

@CharliePoole
CharliePoole deleted the branch nunit:issue-1726 November 15, 2026 17:14
@oznetmaster oznetmaster reopened this Nov 15, 2026
@oznetmaster
oznetmaster changed the base branch from issue-1726 to main November 15, 2026 17:41
@oznetmaster
oznetmaster force-pushed the test/registered-provider-regressions-20261113 branch 2 times, most recently from 3e623a5 to eed7e17 Compare November 15, 2026 17:43

Copy link
Copy Markdown
Collaborator Author

@CharliePoole, we reopened #1965 while refreshing it onto main after #1964 merged and its base branch was deleted. We treated the closure as part of that branch cleanup and should have checked your intention first.

It now contains only the six test files, remains a draft, and passes CI. Did you intend it to stay closed? We can close it again if so. No merges from us.

Neil Colvin, with assistance from OpenAI Codex.

@CharliePoole CharliePoole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tests again. Much of what's here is already in main now, but the merge should take care of that.

// return Services.TestAgentServiceExitTests.RunChild(args);
if (args.Length > 0 && args[0] == "--agent-exit-child")
return Services.TestAgentServiceExitTests.RunChild(args);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, we should talk about why these need to be separately run from the normal tests and whether it's possible to integrate them further. Comments here would be helpful as well. (Not a blocking request)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CharliePoole Added XML remarks beside the helper dispatch. The fixtures already run in the normal suite. Only their native-exit and provider-server helpers use child processes: an unhandled Process.Exited callback must fail its isolated probe instead of terminating the whole suite, while connection-loss and stdin-EOF ownership need a real process boundary. Ordinary ownership/retry assertions stay in-process. The refreshed required suites pass 479 cases on net462 and 471 on net10.0, with zero failures and 19 existing skips each.

Prepared with assistance from OpenAI Codex.

@CharliePoole

Copy link
Copy Markdown
Member

Regarding the tests, please just use your own judgement. Merge if it's an improvement.

Restore ownership, native exit and local release regression helpers using service registration. Document why isolated child modes are part of normal suite execution.

Co-authored-by: OpenAI Codex <codex@openai.com>
@oznetmaster
oznetmaster force-pushed the test/registered-provider-regressions-20261113 branch from eed7e17 to 5e0e14a Compare November 15, 2026 22:46
@oznetmaster
oznetmaster marked this pull request as ready for review November 15, 2026 22:47
@oznetmaster
oznetmaster merged commit f581bf7 into nunit:main Nov 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants