Skip to content

Re-enable provider server integration tests - #1937

Merged
oznetmaster merged 1 commit into
nunit:mainfrom
oznetmaster:fix/re-enable-provider-integration
Nov 15, 2026
Merged

oznetmaster merged 1 commit into
nunit:mainfrom
oznetmaster:fix/re-enable-provider-integration

Conversation

@oznetmaster

@oznetmaster oznetmaster commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Remove the single "Unexplained errors" Ignore from TestAgentProviderServerTests. The provider-server helper modes are restored by merged #1965; this PR changes only the fixture attribute, on main f581bf7.

Fresh Windows validation:

  • The independent public refresh passes Required net462: 490 cases; net10.0: 482 cases. Zero failures and eight existing skips each.
  • On the combined candidate including separately approved Select local launchers using the resolved execution runtime #1947, all 11 integration cases pass on each runtime and both Required suites pass 499 cases, with zero failures and eight existing skips each.
  • Release builds and diff whitespace checks pass; no production workaround, dependency change or new exclusion.

These results demonstrate that the fixture passes on this source. They do not establish the cause of the earlier unexplained failures. Fresh hosted CI must pass before merge.

Prepared by Neil Colvin with assistance from OpenAI Codex.

@CharliePoole

CharliePoole commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

@oznetmaster When I updated main prior to my last commit I discovered that the tests no longer passed. I Ignored that test fixture and forgot to notify you of the problem. I'll pull this branch down and try again.

@oznetmaster
oznetmaster force-pushed the fix/re-enable-provider-integration branch from 69e2858 to 1155711 Compare November 12, 2026 13:19

Copy link
Copy Markdown
Collaborator Author

@CharliePoole I refreshed the one-attribute removal against current main 3615ea2c. All 11 cases pass on both Windows targets, including within the normal full-suite run, and all 11 also pass on native macOS ARM64 and Linux ARM64 using the identical managed .NET 10 payload. The full Windows Required reports contain 2,147 passed and zero failed; the non-pass counts and scope are recorded in the updated description. Cleanup is independently confirmed.

This still does not explain the original failures you saw. If you encounter them again, the test name, exception and OS/runtime would help us target that specific failure. The refreshed change is ready for review.

Neil Colvin, with assistance from OpenAI Codex.

Copy link
Copy Markdown
Collaborator Author

@CharliePoole, the refreshed hosted run passed the required test phase, including the re-enabled fixture. It stopped later in Package: the existing LatestDevBuild check expected API beta.101.3, while the Common nupkg's dependency groups still contain the coordinated beta.101.2 pin.

I tested beta.101.3 separately. The pin alone fails compilation on both engine targets because ServiceContext does not yet implement the new IServiceLocator.GetServices() from your b15a09ba API commit. A small separate engine adaptation now builds cleanly, passes TestAll and the exact Common package gate without relaxing verification. I have kept that production change out of this fixture-only PR.

The broader local Package run also exposes the three modern-Console launcher cases already covered by #1947; unchanged main reproduces their exact result summaries/messages. They are recorded separately from this hosted package-version failure.

Neil Colvin, with assistance from OpenAI Codex.

@CharliePoole CharliePoole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's well time for this.

Co-authored-by: OpenAI Codex <codex@openai.com>
@oznetmaster
oznetmaster force-pushed the fix/re-enable-provider-integration branch from 1155711 to 35eb199 Compare November 15, 2026 22:55

Copy link
Copy Markdown
Collaborator Author

@CharliePoole Refreshed onto main after #1965 restored the provider-server helpers. The diff remains exactly one removed Ignore attribute. All 11 integration cases pass on both runtimes; the independent Required suites pass 490 cases on net462 and 482 on net10.0, with zero failures and eight remaining skips each. The combined candidate with #1947 passes 499 cases on each runtime. Fresh hosted CI is running before merge. These passing results do not establish the cause of the original unexplained failure.

Prepared with assistance from OpenAI Codex.

@oznetmaster
oznetmaster merged commit 5f1dae5 into nunit:main Nov 15, 2026
2 checks passed

Copy link
Copy Markdown
Collaborator Author

@CharliePoole Merged as 5f1dae5 after fresh CI 43771971369 passed, including package verification. Final main is byte-identical to the combined source tested locally: 499 Required engine cases passed on each runtime, zero failures and eight existing skips each. The final diff for this PR remains the single removed Ignore attribute.

Prepared with assistance from OpenAI Codex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants